hammer/todo-app-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Compare commits

base: hammer:160d6014df2489de3f500f03bee76c2e1d7cc185
Branches Tags
hammer:main
..
compare: hammer:5a4d7e0ba9296f7da6712693720b8940a0d9e986
Branches Tags
hammer:main

2 Commits
160d6014df ... 5a4d7e0ba9

Author SHA1 Message Date
Hammer
5a4d7e0ba9 fix: resolve ESLint errors for CI
Some checks failed
CI/CD / test (push) Failing after 1m23s
Details
CI/CD / deploy (push) Has been skipped
Details 
- Remove unused imports (Flag, Tag, Hash, User, FolderPlus, Check, Plus, Link, cn, formatDate, getPriorityLabel)
- Remove unused variable (inbox in Sidebar)
- Fix empty catch block with comment
- Replace any types with proper Mock/Record types in tests
- Suppress set-state-in-effect for intentional form state sync
- Remove unused get parameter from zustand store
 2026-01-30 03:00:17 +00:00
Hammer
1087da5fd8 ci: add Gitea Actions CI/CD workflow 2026-01-29 23:18:08 +00:00
10 changed files with 26 additions and 27 deletions
Expand all files Collapse all files

2
dist/index.html vendored
View File

@@ -6,7 +6,7 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<meta name="description" content="Todo App - Task management made simple" />
<title>Todo App</title>
<script type="module" crossorigin src="/assets/index-BYeSixg2.js"></script>
<script type="module" crossorigin src="/assets/index-BJQCGGBb.js"></script>
<link rel="stylesheet" crossorigin href="/assets/index-C44jgAFE.css">
</head>
<body>

2
src/components/AddTask.tsx
View File

@@ -1,5 +1,5 @@
import { useState, useRef, useEffect } from 'react';
import { Plus, Calendar, Flag, Tag, X } from 'lucide-react';
import { Plus, Calendar, X } from 'lucide-react';
import type { Priority } from '@/types';
import { cn, getPriorityColor } from '@/lib/utils';
import { useTasksStore } from '@/stores/tasks';

1
src/components/CompletedSection.tsx
View File

@@ -1,7 +1,6 @@
import { useState } from 'react';
import { ChevronRight, ChevronDown, Check } from 'lucide-react';
import type { Task } from '@/types';
import { cn } from '@/lib/utils';
import { useTasksStore } from '@/stores/tasks';
interface CompletedSectionProps {

5
src/components/Sidebar.tsx
View File

@@ -2,7 +2,7 @@ import { useState, useRef, useEffect } from 'react';
import { Link, useLocation, useNavigate } from 'react-router-dom';
import {
Inbox, Calendar, CalendarDays, Plus, ChevronDown, ChevronRight,
Hash, Settings, LogOut, User, FolderPlus, Tag, X, Check,
Settings, LogOut, Tag, X,
PanelLeftClose, PanelLeftOpen
} from 'lucide-react';
import { cn } from '@/lib/utils';
@@ -56,7 +56,7 @@ export function Sidebar({ mobileOpen, onMobileClose }: SidebarProps) {
setIsCollapsed(next);
try {
localStorage.setItem(SIDEBAR_COLLAPSED_KEY, String(next));
} catch {}
} catch { /* ignore localStorage errors */ }
};
const handleNavClick = () => {
@@ -94,7 +94,6 @@ export function Sidebar({ mobileOpen, onMobileClose }: SidebarProps) {
navigate('/login');
};
const inbox = projects.find(p => p.isInbox);
const regularProjects = projects.filter(p => !p.isInbox);
const navItems = [

6
src/components/TaskDetail.tsx
View File

@@ -4,7 +4,7 @@ import {
Tag, MessageSquare, ChevronRight, AlertCircle, Layers
} from 'lucide-react';
import type { Task, Priority, Comment, Section } from '@/types';
import { cn, formatDate, getPriorityColor, getPriorityLabel } from '@/lib/utils';
import { cn, getPriorityColor } from '@/lib/utils';
import { useTasksStore } from '@/stores/tasks';
import { api } from '@/lib/api';
@@ -29,7 +29,9 @@ export function TaskDetail({ task, onClose }: TaskDetailProps) {
const titleRef = useRef<HTMLInputElement>(null);
const panelRef = useRef<HTMLDivElement>(null);
// Sync local state from task prop - intentional setState in effect for controlled form
useEffect(() => {
// eslint-disable-next-line react-hooks/set-state-in-effect -- syncing local form state from prop
setTitle(task.title);
setDescription(task.description || '');
setDueDate(task.dueDate ? task.dueDate.slice(0, 10) : '');
@@ -50,7 +52,7 @@ export function TaskDetail({ task, onClose }: TaskDetailProps) {
if (projectId) {
const proj = projects.find(p => p.id === projectId);
if (proj?.sections) {
setAvailableSections(proj.sections);
setAvailableSections(proj.sections); // eslint-disable-line react-hooks/set-state-in-effect
} else {
api.getProject(projectId).then((p) => {
setAvailableSections(p.sections || []);

28
src/lib/__tests__/api.test.ts
View File

@@ -1,25 +1,23 @@
import { describe, it, expect, vi, beforeEach } from 'vitest';
import type { Mock } from 'vitest';
// We need to test the ApiClient class, so we import the module fresh
// The api.ts uses import.meta.env.PROD which is false in test
// So API_BASE = '/api' and AUTH_BASE = ''
let ApiClient: any;
let api: any;
let api: Record<string, (...args: unknown[]) => unknown>;
beforeEach(async () => {
vi.resetModules();
vi.stubGlobal('fetch', vi.fn());
const mod = await import('@/lib/api');
api = mod.api;
// Get the class from the singleton
ApiClient = (api as any).constructor;
api = mod.api as unknown as Record<string, (...args: unknown[]) => unknown>;
});
function mockFetchResponse(data: any, ok = true, status = 200) {
(fetch as any).mockResolvedValueOnce({
function mockFetchResponse(data: unknown, ok = true, _status = 200) {
(fetch as Mock).mockResolvedValueOnce({
ok,
status,
status: _status,
json: () => Promise.resolve(data),
});
}
@@ -42,7 +40,7 @@ describe('ApiClient', () => {
});
it('throws on failed login', async () => {
(fetch as any).mockResolvedValueOnce({
(fetch as Mock).mockResolvedValueOnce({
ok: false,
json: () => Promise.resolve({ message: 'Invalid credentials' }),
});
@@ -78,7 +76,7 @@ describe('ApiClient', () => {
});
it('returns null when not authenticated', async () => {
(fetch as any).mockResolvedValueOnce({
(fetch as Mock).mockResolvedValueOnce({
ok: false,
json: () => Promise.resolve({}),
});
@@ -88,7 +86,7 @@ describe('ApiClient', () => {
});
it('returns null on network error', async () => {
(fetch as any).mockRejectedValueOnce(new Error('Network error'));
(fetch as Mock).mockRejectedValueOnce(new Error('Network error'));
const result = await api.getSession();
expect(result).toBeNull();
@@ -165,7 +163,7 @@ describe('ApiClient', () => {
await api.getTasks({ projectId: 'proj1', completed: false, today: true });
const calledUrl = (fetch as any).mock.calls[0][0] as string;
const calledUrl = (fetch as Mock).mock.calls[0][0] as string;
expect(calledUrl).toContain('/api/tasks?');
expect(calledUrl).toContain('projectId=proj1');
expect(calledUrl).toContain('completed=false');
@@ -259,14 +257,14 @@ describe('ApiClient', () => {
await api.getProjects();
const headers = (fetch as any).mock.calls[0][1].headers;
const headers = (fetch as Mock).mock.calls[0][1].headers;
expect(headers['Authorization']).toBeUndefined();
});
});
describe('Error handling', () => {
it('throws error with message from non-200 response', async () => {
(fetch as any).mockResolvedValueOnce({
(fetch as Mock).mockResolvedValueOnce({
ok: false,
json: () => Promise.resolve({ error: 'Not found' }),
});
@@ -275,7 +273,7 @@ describe('ApiClient', () => {
});
it('throws "Request failed" when error body is unparseable', async () => {
(fetch as any).mockResolvedValueOnce({
(fetch as Mock).mockResolvedValueOnce({
ok: false,
json: () => Promise.reject(new Error('parse error')),
});

3
src/pages/Board.tsx
View File

@@ -16,7 +16,7 @@ interface BoardViewProps {
}
function TaskCard({ task, muted }: { task: Task; muted?: boolean }) {
const { toggleComplete, setSelectedTask } = useTasksStore();
const { setSelectedTask } = useTasksStore();
const overdue = !task.isCompleted && isOverdue(task.dueDate);
return (
@@ -84,6 +84,7 @@ function EditableHeader({
title,
count,
sectionId,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
projectId,
onRename,
onDelete,

2
src/pages/Login.tsx
View File

@@ -1,5 +1,5 @@
import { useState } from 'react';
import { useNavigate, Link } from 'react-router-dom';
import { useNavigate } from 'react-router-dom';
import { useAuthStore } from '@/stores/auth';
export function LoginPage() {

2
src/pages/Project.tsx
View File

@@ -1,6 +1,6 @@
import { useEffect, useState, useRef } from 'react';
import { useParams, useNavigate, useLocation } from 'react-router-dom';
import { LayoutList, LayoutGrid, Plus, Pencil, Trash2, AlertCircle } from 'lucide-react';
import { LayoutList, LayoutGrid, Pencil, Trash2, AlertCircle } from 'lucide-react';
import { cn } from '@/lib/utils';
import { useTasksStore } from '@/stores/tasks';
import { TaskItem } from '@/components/TaskItem';

2
src/stores/auth.ts
View File

@@ -17,7 +17,7 @@ interface AuthState {
export const useAuthStore = create<AuthState>()(
persist(
(set, get) => ({
(set) => ({
user: null,
isLoading: true,
isAuthenticated: false,